Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/openrbg: set cpu model based on what microcode updates are enabled #253048

Merged
merged 1 commit into from
Sep 7, 2023
Merged

nixos/openrbg: set cpu model based on what microcode updates are enabled #253048

merged 1 commit into from
Sep 7, 2023

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 3, 2023

nixos-generate-config sets either of these, so lets use them

Description of changes

NixOS/nixos-hardware#709

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 3, 2023
@Mic92
openrbg: set default based on what microcode updates are enabled
f6fa02c 
nixos-generate-config sets either of these, so lets use them
@Mic92 Mic92 mentioned this pull request Sep 3, 2023
Closed
2 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Sep 3, 2023
khaneliman
khaneliman approved these changes Sep 3, 2023
View reviewed changes
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, love it.

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Sep 6, 2023
@wegank wegank merged commit eb1c345 into NixOS:master Sep 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasew lucasew lucasew approved these changes

@khaneliman khaneliman khaneliman approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mic92 @khaneliman @lucasew @wegank