sunpaper: add meta.mainProgram, fix license, and other cleanup #256437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: clean-up
11.by: package-maintainer
wegank
reviewed
Sep 21, 2023
| --replace "sunwait" "${sunwait}/bin/sunwait" \ | ||
| --replace "setwallpaper" "${wallutils}/bin/setwallpaper" \ | ||
| --replace "sunwait" "${lib.getExe sunwait}" \ | ||
| --replace "setwallpaper" "${lib.getExe' wallutils "setwallpaper"}" \ |
There was a problem hiding this comment.
Learning something new every day.
toastal
pushed a commit
to toastal/nixpkgs
that referenced
this pull request
Sep 25, 2023
…#256437) * sunpaper: fix meta * sunpaper: replace rec with finalAttrs idiom * sunpaper: use lib.getExe * sunpaper: fix installPhase * sunpaper: move to pkgs/by-name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix
meta:meta.maintainersmeta.mainProgrammeta.platforms, as this is a Linux program per upstreamwith lib;(see Tracking issue: remove overuses ofwith lib;#208242)Other cleanup:
finalAttrsidiom instead ofrec(see https://nixos.org/manual/nixpkgs/stable/#mkderivation-recursive-attributes)lib.getExesha256withhashpkgs/by-namestructureThings done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)