-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openbangla-keyboard: 2.0.0 -> unstable-2023-07-21; add fcitx5 support #258314
Conversation
13b8f0a
to
6cf9506
Compare
6cf9506
to
2c6b59c
Compare
Perhaps the
Besides that, both of |
Thanks, I completely blanked on the package deprecation process. I'll take a look at that |
2c6b59c
to
ff3bd46
Compare
ff3bd46
to
fb8cb20
Compare
I've removed the existing attribute, thanks for the suggestion! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the ibus engine and it works
@eclairevoyant... fcitx5 will not work with OpenBangla Keyboard 2.0. It will work with OpenBangla Keyboard built from the develop branch of OpenBangla Keyboard's github repository till now. |
Description of changes
meta
with lib;
(see Tracking issue: remove overuses ofwith lib;
#208242)openbangla-keyboard
from top-level, added throws alias for thatibus-engines.openbangla-keyboard
andfcitx5-openbangla-keyboard
)I see there's a discrepancy with how ibus and fcitx5 handle their packages, but I didn't want to create a pattern that's never been seen before in nixpkgs.
Closes #182388
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)