Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openbangla-keyboard: 2.0.0 -> unstable-2023-07-21; add fcitx5 support #258314

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

eclairevoyant
Copy link
Contributor

@eclairevoyant eclairevoyant commented Oct 1, 2023

Description of changes

  • 2.0.0 -> unstable-2023-07-21
    • needed for fcitx5 support
  • fix meta
  • fix IME support (ibus, fcitx5)
  • remove existing package in favour of the IME-specific ones
    • Removed openbangla-keyboard from top-level, added throws alias for that
    • Added two new packages (ibus-engines.openbangla-keyboard and fcitx5-openbangla-keyboard)

I see there's a discrepancy with how ibus and fcitx5 handle their packages, but I didn't want to create a pattern that's never been seen before in nixpkgs.

Closes #182388

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from hqurve October 1, 2023 02:25
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 1, 2023
@eclairevoyant eclairevoyant marked this pull request as ready for review October 1, 2023 02:36
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package and removed 10.rebuild-linux: 1 labels Oct 1, 2023
@hqurve
Copy link
Contributor

hqurve commented Oct 1, 2023

Perhaps the openbangla-keyboard derivation should be deprecated (placed in aliases.nix with a message suggesting ibus-engines.openbangla-keyboard and fcitx5-openbangla-keyboard) since the build fails with

 > CMake Error at CMakeLists.txt:79 (message):
>   Please set atleast ENABLE_IBUS or ENABLE_FCITX to be ON to build a backend

Besides that, both of ibus-engines.openbangla-keyboard and fcitx5-openbangla-keyboard build.

@eclairevoyant
Copy link
Contributor Author

Thanks, I completely blanked on the package deprecation process. I'll take a look at that

@eclairevoyant eclairevoyant marked this pull request as ready for review October 10, 2023 05:22
@eclairevoyant
Copy link
Contributor Author

I've removed the existing attribute, thanks for the suggestion!

Copy link
Contributor

@hqurve hqurve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the ibus engine and it works

@eclairevoyant eclairevoyant added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 13, 2023
@thiagokokada thiagokokada merged commit b96d352 into NixOS:master Oct 19, 2023
22 checks passed
@eclairevoyant eclairevoyant deleted the openbangla-keyboard branch October 19, 2023 17:25
@asifakonjee
Copy link

@eclairevoyant... fcitx5 will not work with OpenBangla Keyboard 2.0. It will work with OpenBangla Keyboard built from the develop branch of OpenBangla Keyboard's github repository till now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants