Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bibata-cursors: 2.0.3 -> 2.0.6; move to pkgs/by-name and fix meta #261532

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

eclairevoyant
Copy link
Contributor

@eclairevoyant eclairevoyant commented Oct 17, 2023

Description of changes

Move to pkgs/by-name, bump version, fix meta (remove with lib; as per #208242, and fix license)
Fixes #260804.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from rawkode October 17, 2023 01:49
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 17, 2023
@kilianar

This comment was marked as resolved.

@eclairevoyant eclairevoyant marked this pull request as draft October 17, 2023 13:51
@eclairevoyant

This comment was marked as outdated.

@eclairevoyant eclairevoyant added the 2.status: work-in-progress This PR isn't done label Oct 18, 2023
@Schweber
Copy link
Contributor

Hi, any news on this?

updates build process based on some upstream breaking changes, and preserves pre/post-hook phases
@eclairevoyant eclairevoyant marked this pull request as ready for review January 27, 2024 00:22
@eclairevoyant eclairevoyant changed the title bibata-cursors: 2.0.3 -> 2.0.4; fix meta bibata-cursors: 2.0.3 -> 2.0.6; move to pkgs/by-name and fix meta Jan 27, 2024
@quantenzitrone
Copy link
Contributor

Result of nixpkgs-review pr 261532 run on x86_64-linux 1

1 package built:
  • bibata-cursors

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 8, 2024
@wegank wegank merged commit 7926b58 into NixOS:master Mar 25, 2024
24 checks passed
@eclairevoyant eclairevoyant deleted the bibata-cursors branch March 25, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: work-in-progress This PR isn't done 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: bibata-cursors 2.0.3 → 2.0.4
5 participants