mouse-actions: init at 0.4.4

[rgri]

Description of changes

https://github.com/jersou/mouse-actions

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[donovanglover]

Thanks for contributing to nixpkgs!

[rgri]

Alright thanks for the criticism! ^-^ I think I've resolved everything so far. However not too sure how I should organize my commits, is it ok for there to be so many? Specifically the last one which moves and renames default.nix.

[donovanglover]

1 for the maintainer and 1 for the package would be ideal 👍

[rgri]

Alright, I think I've done it.

[donovanglover]

Result of nixpkgs-review pr 265056 run on x86_64-linux 1

1 package failed to build:

• mouse-actions

I got it to run after changing cargoHash but it crashes for me. Don't know how we usually handle groups in nixpkgs.

[2023-11-02T19:16:00Z ERROR mouse_actions::process_args] Grab Error: IoError(
        Os {
            code: 13,
            kind: PermissionDenied,
            message: "Permission denied",
        },
    )
[2023-11-02T19:16:00Z ERROR mouse_actions::process_args] The user must be in the file group of /dev/input files, usually 'input' or 'plugdev' :
[2023-11-02T19:16:00Z ERROR mouse_actions::process_args]   $ sudo usermod -a -G input $USER
[2023-11-02T19:16:00Z ERROR mouse_actions::process_args]   $ sudo usermod -a -G plugdev $USER
[2023-11-02T19:16:00Z ERROR mouse_actions::process_args]   $ sudo tee /etc/udev/rules.d/80-mouse-actions.rules <<<'KERNEL=="uinput", SUBSYSTEM=="misc", TAG+="uaccess", OPTIONS+="static_node=uinput"'
[2023-11-02T19:16:00Z ERROR mouse_actions::process_args] Then restart to apply this user modifications.
[2023-11-02T19:16:00Z ERROR mouse_actions::process_args] See https://github.com/jersou/mouse-actions#requirement-

[rgri]

I wasn't sure how to do this either. The upstream doesn't give any solution besides just usermod.

[donovanglover]

Unfortunately I can't approve since I'm unfamiliar with how to proceed from here. Maybe someone else can help out.

[jfvillablanca]

can you squash your commits from the review, ideally there should only be 2 commits

[FliegendeWurst]

I got it to run after changing cargoHash but it crashes for me. Don't know how we usually handle groups in nixpkgs.

Usually a programs.<name>.enable or services.<name>.enable nixos option is added that configures the required permissions.

[rgri]

Usually a programs..enable or services..enable nixos option is added that configures the required permissions.

Alright, I'll look into this tomorrow morning. Would this mean that it technically doesn't work on distros which aren't NixOS, and I should update meta.platforms?

[FliegendeWurst]

Alright, I'll look into this tomorrow morning. Would this mean that it technically doesn't work on distros which aren't NixOS

The package itself can be run on other distros, the user then just needs to set their groups and udev rules manually.

Besides that I don't think it's possible to exclude other distros using meta.platforms. meta.platforms essentially only states for which [OS, CPU architecture] combinations the package should work.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1209

[rgri]

Anything I can do at this point to help get this merged?

[ludat]

I also would like this merged, is there something missing?

[eclairevoyant]

second commit msg can be cleaned up to just one line, otherwise lgtm

[rgri]

I removed the squashed messages, but am leaving the "Co-authored by [...]" lines. Is that OK?

[FliegendeWurst]

I removed the squashed messages, but am leaving the "Co-authored by [...]" lines. Is that OK?

Yes, that is how it is supposed to be done.