Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/dae: fix file location resolve #265270

Closed
wants to merge 5 commits into from
Closed

Conversation

oluceps
Copy link
Member

@oluceps oluceps commented Nov 3, 2023

Description of changes

Fix:
while specifying the subscription file like:

# config.dae
subscription {
    e: 'file://example'
}

It won't be found by the service:

"open /run/credentials/dae.service/example: no such file or directory"

Due to using the LoadCredentials mechanism.

The issue previous pr mentioned should not be an issue since /etc/ actually be managed by nix and not recommended manually edit.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 3, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 3, 2023
@oluceps oluceps marked this pull request as ready for review November 8, 2023 09:03
@oluceps oluceps requested review from pokon548 and drupol November 13, 2023 07:30
Copy link
Contributor

@pokon548 pokon548 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 265270 run on x86_64-linux 1

2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 15, 2023
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 8, 2024
@oluceps
Copy link
Member Author

oluceps commented Mar 18, 2024

link daeuniverse/flake.nix#20

@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Mar 20, 2024
@Aleksanaa Aleksanaa added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 19, 2024
@oluceps
Copy link
Member Author

oluceps commented Aug 20, 2024

outdated.

@oluceps oluceps closed this Aug 20, 2024
@oluceps oluceps deleted the dae-module-fix branch August 20, 2024 06:29
@oluceps
Copy link
Member Author

oluceps commented Aug 20, 2024

For anyone who encounters issue with this module, try flake first.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants