nixos/unifi: Add the ability to specify extra JVM options #266528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
lucasbergman
force-pushed
the
unifi-jvmoptions
branch
2 times, most recently
from
9c96d2f
to
bde73ef
Compare
|
Hi @wegank by chance would you be interested in having a look at this? Forgive me if there's other protocol; I haven't committed to nixpkgs before. No rush. |
wegank
reviewed
Nov 11, 2023
This removes "with lib", which advances NixOS#208242 a bit, and cleans up a few formatting nits found by nixfmt.
There's no functionality change here, but this makes it a bit more convenient to add more args.
lucasbergman
force-pushed
the
unifi-jvmoptions
branch
from
bde73ef
to
7329694
Compare
This can be useful for adding extra logging, tweaking garbage collector parameters, and for using JMX to monitor the JVM.
lucasbergman
force-pushed
the
unifi-jvmoptions
branch
from
7329694
to
07828dc
Compare
wegank
approved these changes
Nov 12, 2023
delroth
added
the
12.approvals: 1
|
Thanks very much for the review/approval. Does someone come by and merge this at some point? Sorry, I'm still new at this. |
|
Hi @wegank or anyone else, do I need to do anything else for this to get merged? |
|
I'll merge it. Would you also like to have a look at #195448 (comment), as I assume you are an active UniFi user? It would be nice if we could upgrade to MongoDB 5.0 for the upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The first two commits do some throat clearing, just cleaning up some formatting and making the command line args a list instead of a big string. The third commit gives me the ability to give the JVM zany options so I can watch its allocator and GC behavior, or monitor it with Prometheus using something like jmx_exporter.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)