Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitbox: init at 4.39.0 #267064

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

bitbox: init at 4.39.0 #267064

wants to merge 9 commits into from

Conversation

tensor5
Copy link
Contributor

@tensor5 tensor5 commented Nov 12, 2023

Description of changes

Add package for BitBox02 hardware wallet desktop app.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the program coredumps :(

./result/bin/bitbox       

(bitbox:118158): Gtk-WARNING **: 19:50:42.895: Unable to locate theme engine in module_path: "adwaita",
Cannot mix incompatible Qt library (5.15.11) with this library (5.15.10)
[1]    118158 abort (core dumped)  ./result/bin/bitbox

Why are you adding all the udev rules shouldn't they be in the upstream project?

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/applications/blockchains/bitbox/default.nix Outdated Show resolved Hide resolved
pkgs/applications/blockchains/bitbox/default.nix Outdated Show resolved Hide resolved
pkgs/applications/blockchains/bitbox/default.nix Outdated Show resolved Hide resolved
pkgs/applications/blockchains/bitbox/default.nix Outdated Show resolved Hide resolved
pkgs/applications/blockchains/bitbox/default.nix Outdated Show resolved Hide resolved
pkgs/applications/blockchains/bitbox/default.nix Outdated Show resolved Hide resolved
@tensor5
Copy link
Contributor Author

tensor5 commented Jan 27, 2024

Is there anything that needs to be done to get this PR merged?

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label May 5, 2024
@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 267064 run on aarch64-darwin 1

1 package failed to build:
  • bitbox

@RaghavSood
Copy link
Member

RaghavSood commented May 12, 2024

This fails to build on darwin (aarch64/M2)

out.txt

If that can't be fixed, the platforms should be limited to linux instead of unix

@tensor5
Copy link
Contributor Author

tensor5 commented May 13, 2024

If that can't be fixed, the platforms should be limited to linux instead of unix

Thanks @RaghavSood, 55d9272fd3c3934ef46189d1324c7ffc23b32275.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels May 13, 2024
@tensor5
Copy link
Contributor Author

tensor5 commented Oct 13, 2024

Hi. Is anything stopping this PR from being merged?

pkgs/applications/blockchains/bitbox/default.nix Outdated Show resolved Hide resolved
pkgs/applications/blockchains/bitbox/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants