Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/modules/installer/cd-dvd/iso-image: improved grub and media config #279994

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nixos/modules/installer/cd-dvd/iso-image: improved grub and media config #279994

wants to merge 1 commit into from

Conversation

gray-heron
Copy link

@gray-heron gray-heron commented Jan 10, 2024 •
edited
Loading

Description of changes

Added capability to add custom grub options and modify contents of the Boot Catalog of the iso images produced by the iso-image installer module. This, for example, allows users to create custom, pre-installation, pre-boot routines, such as hardware tests, BIOS updates, etc.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Extensively tested added functionality
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 10, 2024
@gray-heron gray-heron self-assigned this Jan 10, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Jan 10, 2024
@gray-heron gray-heron force-pushed the feature/boot-contents2 branch 4 times, most recently from 92306d4 to b622c43 Compare January 10, 2024 16:02
@gray-heron gray-heron requested a review from nbp February 23, 2024 09:29
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3764

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
@gray-heron gray-heron requested review from ElvishJerricco and removed request for samueldr October 26, 2024 09:20
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@nbp nbp Awaiting requested review from nbp

@ElvishJerricco ElvishJerricco Awaiting requested review from ElvishJerricco

Assignees

@gray-heron gray-heron

Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gray-heron @nixos-discourse @SuperSandro2000 @wegank