-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/mautrix-discord: init #284421
base: master
Are you sure you want to change the base?
nixos/mautrix-discord: init #284421
Conversation
Result of 1 package blacklisted:
|
f8594ee
to
c00a1ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to add the test file to nixos/tests/all-tests.nix
. Other than that, LGTM.
c00a1ff
to
b1b5fcf
Compare
mautrix-discord has already been packaged, but as of yet no NixOS module has been provided. This is the same module that I've revived from NixOS#200462, but now with expanded hardening.
b1b5fcf
to
b594aeb
Compare
Hello, I have a few notes,
|
I have recently Made pr with mautrix-meta service that has data dir configurable, so you can take a look. #296718 |
Hello ! Is there anything new about this module ? Can I use it safely on my homeserver ? |
Description of changes
mautrix-discord has already been packaged, but as of yet no NixOS module has been provided. This is the same module that I've revived from #200462, but now with expanded hardening.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.