Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roslyn-ls: init at 4.10.0-2.24102.11 #285645

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

konradmalik
Copy link
Contributor

@konradmalik konradmalik commented Feb 1, 2024

Description of changes

VSCode C# Dev Toolkit released in 2023 introduced a new roslyn-based LSP server.

In this PR I propose to introduce this underlying LSP server to nixpkgs.
roslyn-ls is already integrated in neovim via a new plugin as well an ongoing effort to integrate it into emacs.

There is also a thread in nvim-lspconfig that can also shine a bit of light on the history of this server.

The release process of this server is a bit convoluted, but my TL;DR understanding is:

  • the server is hosted in dotnet/roslyn repository
  • dotnet/roslyn repo creates a tag VSCode-CSharp-2.16.24 which builds this server and pushes it to nuget (not sure about that but such tags are being created on that repo and the server is for sure published to nuget)
  • version of the server is based on the general roslyn version, not vscode-csharp version
  • dotnet/vscode-csharp bumps the roslyn-ls version and tags a new release - 2.16.24 (also not sure about that but tags in vscode-csharp match tags in dotnet/roslyn)

Also related to naming - wanted to use roslyn but it's already used in nixpkgs so I went with roslyn-ls.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@konradmalik konradmalik marked this pull request as ready for review February 2, 2024 08:18
@konradmalik konradmalik marked this pull request as draft February 2, 2024 09:59
@konradmalik konradmalik changed the title roslyn-ls: init at 4.10.0-1 roslyn-ls: init at 4.9.0-3 Feb 2, 2024
@konradmalik konradmalik marked this pull request as ready for review February 2, 2024 16:45
@konradmalik konradmalik changed the title roslyn-ls: init at 4.9.0-3 roslyn-ls: init at 4.10.0-1 Feb 4, 2024
@konradmalik konradmalik changed the title roslyn-ls: init at 4.10.0-1 roslyn-ls: init at 4.10.0-1.24069.13 Feb 4, 2024
@konradmalik konradmalik force-pushed the roslyn-ls branch 3 times, most recently from a0febbc to 479d676 Compare February 4, 2024 18:06
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3391

pkgs/by-name/ro/roslyn-ls/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ro/roslyn-ls/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ro/roslyn-ls/package.nix Show resolved Hide resolved
@konradmalik konradmalik changed the title roslyn-ls: init at 4.10.0-1.24069.13 roslyn-ls: init at 4.10.0-2.24102.11 Feb 12, 2024
@SuperSandro2000 SuperSandro2000 merged commit e1de6da into NixOS:master Feb 17, 2024
25 checks passed
@konradmalik konradmalik deleted the roslyn-ls branch February 18, 2024 09:51
@konradmalik konradmalik restored the roslyn-ls branch February 18, 2024 09:54
@konradmalik konradmalik deleted the roslyn-ls branch February 18, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants