-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roslyn-ls: init at 4.10.0-2.24102.11 #285645
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Feb 1, 2024
konradmalik
force-pushed
the
roslyn-ls
branch
from
February 2, 2024 07:48
10aa094
to
323fb12
Compare
konradmalik
force-pushed
the
roslyn-ls
branch
from
February 2, 2024 08:20
323fb12
to
6955e43
Compare
konradmalik
force-pushed
the
roslyn-ls
branch
from
February 2, 2024 16:32
6d1b7a5
to
9316147
Compare
konradmalik
force-pushed
the
roslyn-ls
branch
from
February 4, 2024 13:58
5dfbf71
to
5a52686
Compare
konradmalik
changed the title
roslyn-ls: init at 4.10.0-1
roslyn-ls: init at 4.10.0-1.24069.13
Feb 4, 2024
konradmalik
force-pushed
the
roslyn-ls
branch
3 times, most recently
from
February 4, 2024 18:06
a0febbc
to
479d676
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3391 |
konradmalik
force-pushed
the
roslyn-ls
branch
from
February 6, 2024 17:30
479d676
to
18569d9
Compare
konradmalik
force-pushed
the
roslyn-ls
branch
from
February 12, 2024 20:28
18569d9
to
c6f4ab4
Compare
konradmalik
changed the title
roslyn-ls: init at 4.10.0-1.24069.13
roslyn-ls: init at 4.10.0-2.24102.11
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
VSCode C# Dev Toolkit released in 2023 introduced a new roslyn-based LSP server.
In this PR I propose to introduce this underlying LSP server to nixpkgs.
roslyn-ls
is already integrated in neovim via a new plugin as well an ongoing effort to integrate it into emacs.There is also a thread in nvim-lspconfig that can also shine a bit of light on the history of this server.
The release process of this server is a bit convoluted, but my TL;DR understanding is:
Also related to naming - wanted to use
roslyn
but it's already used in nixpkgs so I went withroslyn-ls
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.