Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfsUnstable: 2.2.3-unstable-2024-02-12 → 2.2.4-unstable-2024-03-21 #297808

Merged
merged 1 commit into from
Mar 23, 2024
Merged

zfsUnstable: 2.2.3-unstable-2024-02-12 → 2.2.4-unstable-2024-03-21 #297808

merged 1 commit into from
Mar 23, 2024

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Mar 21, 2024

Has patch to fix 6.8 issue

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

1

Footnotes

  1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project.
    I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute. ↩

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Mar 21, 2024
@toastal
Copy link
Contributor Author

toastal commented Mar 22, 2024

Succeeds unmerged #291402

@toastal toastal mentioned this pull request Mar 22, 2024
Closed
13 tasks
amarshall
amarshall reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@amarshall amarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully ran nix-build -A nixosTests.zfs.unstable

pkgs/os-specific/linux/zfs/unstable.nix Outdated Show resolved Hide resolved
@toastal toastal force-pushed the zfsUnstable-2.2.4-staging-1 branch from e27d60a to ff35821 Compare March 22, 2024 16:12
@toastal toastal force-pushed the zfsUnstable-2.2.4-staging-1 branch from ff35821 to 8107bc5 Compare March 22, 2024 16:13
@adamcstephens
Copy link
Contributor

@ofborg test zfs.unstable

@adamcstephens adamcstephens merged commit 13bdb7b into NixOS:master Mar 23, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarshall amarshall amarshall approved these changes

@adamcstephens adamcstephens Awaiting requested review from adamcstephens

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toastal @adamcstephens @amarshall