weblate: init at 5.6.2, add module #325541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: nixos
wegank
reviewed
Jul 8, 2024
wegank
reviewed
Jul 8, 2024
wegank
reviewed
Jul 8, 2024
pkgs/development/python-modules/django-cors-headers/default.nix
Outdated
Show resolved
Hide resolved
wegank
reviewed
Jul 8, 2024
wegank
reviewed
Jul 8, 2024
pkgs/development/python-modules/django-timezone-field/default.nix
Outdated
Show resolved
Hide resolved
wegank
reviewed
Jul 8, 2024
wegank
reviewed
Jul 8, 2024
pkgs/development/python-modules/python-fluent/fluent-syntax.nix
Outdated
Show resolved
Hide resolved
wegank
reviewed
Jul 8, 2024
ofborg
bot
requested review from
GetPsyched,
jtojnar,
mtrsk,
mweinelt and
phile314
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-summer-of-nix-program-updates/46053/3 |
This was referenced Jul 8, 2024
13 tasks
Co-authored-by: Taeer Bar-Yam <[email protected]>
Co-authored-by: Jan Tojnar <[email protected]> Co-authored-by: Taeer Bar-Yam <[email protected]>
Co-authored-by: Taeer Bar-Yam <[email protected]>
erictapen
added a commit
to erictapen/ngipkgs
that referenced
this pull request
Aug 12, 2024
erictapen
added a commit
to erictapen/ngipkgs
that referenced
this pull request
Aug 12, 2024
|
Thanks a lot everyone! |
wegank
pushed a commit
to ngi-nix/ngipkgs
that referenced
this pull request
Aug 13, 2024
…25541 (#331) Co-authored-by: Valentin Gagarin <[email protected]>
erictapen
added a commit
to erictapen/ngipkgs
that referenced
this pull request
Aug 13, 2024
This is due to Weblate being merged into Nixpkgs: NixOS/nixpkgs#325541 Poetry2nix was only used by Weblate, so I also removed that
erictapen
added a commit
to erictapen/ngipkgs
that referenced
this pull request
Aug 14, 2024
This is due to Weblate being merged into Nixpkgs: NixOS/nixpkgs#325541 Poetry2nix was only used by Weblate, so I also removed that
wegank
pushed a commit
to erictapen/ngipkgs
that referenced
this pull request
Aug 15, 2024
This is due to Weblate being merged into Nixpkgs: NixOS/nixpkgs#325541 Poetry2nix was only used by Weblate, so I also removed that
wegank
pushed a commit
to ngi-nix/ngipkgs
that referenced
this pull request
Aug 15, 2024
* flake.lock: Update
Flake lock file updates:
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/154bcb95ad51bc257c2ce4043a725de6ca700ef6' (2024-08-09)
→ 'github:NixOS/nixpkgs/daf7bb95821b789db24fc1ac21f613db0c1bf2cb' (2024-08-14)
* weblate: remove package and module, only leave example
This is due to Weblate being merged into Nixpkgs:
NixOS/nixpkgs#325541
Poetry2nix was only used by Weblate, so I also removed that
dotlambda
reviewed
Aug 29, 2024
|
Did anyone even look at the Python packages during review?? |
|
I did, though at the time I wasn't aware of the newer Python package conventions. (missing the |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-reaching-the-right-reviewers/51312/1 |
13 tasks
|
@dotlambda I addressed your reviews in #338217, though I don't really get the strength of your tone. Looks like it was mostly nits, that can just be solved by better linting eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is (afaik) the third attempt to get Weblate into Nixpkgs (#48726, #169797) and is a combination of these efforts, plus my work on a separate flake https://github.com/ngi-nix/weblate which I did for Summer of Nix back then.
Marked as a draft for now, as I might need to file some changes in here as a separate PR. Also the commit structure is kinda messy and is grown over time, I'd do a cleaner rebase once it's ready for review. The project builds though and the NixOS tests run successully.
@jtojnar I included you as maintainer in a few packages you started in #48726, is that okay?
Extra thanks to @summersamara, who helped me through some python madness ❤️ .
Thanks for Summer of Nix to fund this work!
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.