Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel blockers for Rust 1.80 #332176

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Aug 4, 2024

Description of changes

Rust 1.80.0 contains a major unfixable compilation regression that affects all but recent versions of the widely-used "time" crate. This is going to impact a lot of Rust software in Nixpkgs. In this PR, I've focused on identifying packages that would block the channels if we updated to Rust 1.80 without updating them. I can't yet confirm that this is an exhaustive list, but I don't think it's far off.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Required to build with Rust 1.80.

Link: rust-lang/rust#127343
Required to build with Rust 1.80.

Link: rust-lang/rust#127343
@flokli
Copy link
Contributor

flokli commented Aug 5, 2024

Ack on the nsncd change.

@alyssais alyssais merged commit 09d8b50 into NixOS:staging Aug 6, 2024
30 of 31 checks passed
@alyssais alyssais deleted the rust-1.80.0-channel-blockers branch August 6, 2024 06:24
@picnoir
Copy link
Member

picnoir commented Aug 6, 2024

I'm not 100% sure this is fixed on Nsncd's side. See twosigma/nsncd#117 (comment) and https://github.com/srd424/nsncd/actions/runs/10235189099/job/28315666470#step:6:83 .

That's a lot to rebuild, I'll wait for hydra to rebuild everything. I'll fix that upstream if the issue is still here.

@alyssais
Copy link
Member Author

alyssais commented Aug 6, 2024

Hmm, I thought I built it with 1.80, but it's of course possible I could have made a mistake!

@picnoir
Copy link
Member

picnoir commented Aug 6, 2024

Okay, I get it. The 1.4.1 release dates from May 2023 and do not contain the latest network fixes we pushed late 2023. 1.4.1 can be considered as broken for NixOS. We did a rollback here (not your fault just to be clear).

However, 1.4.1 do not depend on time yet (through the term crate). The current main depends on time 0.3.20, so do not have the fix introduced in time 0.3.35.

I'll fix that tonight and ask upstream to cut a new release.

@alyssais
Copy link
Member Author

alyssais commented Aug 6, 2024

Oh no, I must have missed the year!

@picnoir
Copy link
Member

picnoir commented Aug 6, 2024

No worries, mistakes happen. This one is on us: we should cut out a new release.

@picnoir
Copy link
Member

picnoir commented Aug 6, 2024

Upstream issue: twosigma/nsncd#118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants