castor: 0.14.0 -> 0.17.1 #332192
Merged
castor: 0.14.0 -> 0.17.1 #332192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrkwiecinski
requested review from
aanderse,
drupol,
globin,
Ma27 and
talyz
as code owners
drupol
reviewed
Aug 4, 2024
piotrkwiecinski
force-pushed
the
castor-update
branch
from
c346e1b
to
e5fcfe9
Compare
This fixes the generation of bash completion by patching the shebang of the castor script before the generation is excuted.
piotrkwiecinski
force-pushed
the
castor-update
branch
from
e5fcfe9
to
ed0930b
Compare
drupol
approved these changes
Aug 11, 2024
|
@piotrkwiecinski Thanks for your patience! IIRC there's another PR that might need an update using what @jtojnar advised us here. Do you think you could fix it too there? |
|
@drupol yes. I'll pick it up later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/jolicode/castor/releases/tag/v0.15.0
https://github.com/jolicode/castor/releases/tag/v0.16.0
https://github.com/jolicode/castor/releases/tag/v0.17.0
https://github.com/jolicode/castor/releases/tag/v0.17.1
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.