Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vapoursynth-{bm3d,bm3dcuda,bm3dcpu,bm3dhip,dfttest,hqdn3d,knlmeanscl,wnnm},vs-{dfttest2,dfttest2cuda,dfttest2gcc,dfttest2hip,nlm-cuda,nlm-ispc},neo_{dfttest,f3kdb}: init #333321

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

snaakey
Copy link
Member

@snaakey snaakey commented Aug 8, 2024

Description of changes

Added a bunch of vapoursynth plugins

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@snaakey snaakey changed the title vapoursynth-{bm3d,bm3dcuda,bm3dhip,dfttest,hqdn3d,knlmeanscl,wnnm},vs-{dfttest2,nlm-cuda,nlm-ispc},neo_{dfttest,f3kdb} vapoursynth-{bm3d,bm3dcuda,bm3dhip,dfttest,hqdn3d,knlmeanscl,wnnm},vs-{dfttest2,nlm-cuda,nlm-ispc},neo_{dfttest,f3kdb}: init Aug 8, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Aug 9, 2024
@snaakey snaakey force-pushed the vapoursynth-denoise branch 3 times, most recently from aad14d2 to 8fe2541 Compare August 9, 2024 11:05
@snaakey snaakey changed the title vapoursynth-{bm3d,bm3dcuda,bm3dhip,dfttest,hqdn3d,knlmeanscl,wnnm},vs-{dfttest2,nlm-cuda,nlm-ispc},neo_{dfttest,f3kdb}: init vapoursynth-{bm3d,bm3dcuda,bm3dcpu,bm3dhip,dfttest,hqdn3d,knlmeanscl,wnnm},vs-{dfttest2,dfttest2cuda,dfttest2gcc,dfttest2hip,nlm-cuda,nlm-ispc},neo_{dfttest,f3kdb}: init Aug 9, 2024
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 9, 2024
@snaakey snaakey removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 9, 2024
@snaakey snaakey requested a review from illdefined August 9, 2024 11:40
pkgs/by-name/ne/neo_dfttest/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ne/neo_f3kdb/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ne/neo_f3kdb/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/va/vapoursynth-bm3d/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/va/vapoursynth-bm3d/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/va/vapoursynth-wnnm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/va/vapoursynth-wnnm/package.nix Show resolved Hide resolved
pkgs/by-name/va/vapoursynth-wnnm/package.nix Show resolved Hide resolved
pkgs/by-name/vs/vs-dfttest2/package.nix Show resolved Hide resolved
pkgs/by-name/vs/vs-nlm-ispc/package.nix Outdated Show resolved Hide resolved
@illdefined
Copy link
Contributor

Result of nixpkgs-review pr 333321 run on x86_64-linux 1

3 packages failed to build:
  • vs-dfttest2
  • vs-dfttest2cuda
  • vs-dfttest2gcc
13 packages built:
  • neo_dfttest
  • neo_f3kdb
  • vapoursynth-bm3d
  • vapoursynth-bm3dcpu
  • vapoursynth-bm3dcuda
  • vapoursynth-bm3dhip
  • vapoursynth-dfttest
  • vapoursynth-hqdn3d
  • vapoursynth-knlmeanscl
  • vapoursynth-wnnm
  • vs-dfttest2hip
  • vs-nlm-cuda
  • vs-nlm-ispc

@illdefined
Copy link
Contributor

Result of nixpkgs-review pr 333321 run on x86_64-linux 1

16 packages built:
  • neo_dfttest
  • neo_f3kdb
  • vapoursynth-bm3d
  • vapoursynth-bm3dcpu
  • vapoursynth-bm3dcuda
  • vapoursynth-bm3dhip
  • vapoursynth-dfttest
  • vapoursynth-hqdn3d
  • vapoursynth-knlmeanscl
  • vapoursynth-wnnm
  • vs-dfttest2
  • vs-dfttest2cuda
  • vs-dfttest2gcc
  • vs-dfttest2hip
  • vs-nlm-cuda
  • vs-nlm-ispc

@illdefined
Copy link
Contributor

Result of nixpkgs-review pr 333321 run on x86_64-linux 1

16 packages built:
  • neo_dfttest
  • neo_f3kdb
  • vapoursynth-bm3d
  • vapoursynth-bm3dcpu
  • vapoursynth-bm3dcuda
  • vapoursynth-bm3dhip
  • vapoursynth-dfttest
  • vapoursynth-hqdn3d
  • vapoursynth-knlmeanscl
  • vapoursynth-wnnm
  • vs-dfttest2
  • vs-dfttest2cuda
  • vs-dfttest2gcc
  • vs-dfttest2hip
  • vs-nlm-cuda
  • vs-nlm-ispc

@snaakey snaakey added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 9, 2024
@illdefined illdefined added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Aug 9, 2024
@illdefined
Copy link
Contributor

I suppose you could use generic stdenv and cudaPackages parameters instead of specific variants and then provide those as arguments to callPackage in pkgs/top-level/all-packages.nix, but I am not sure how important that is.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants