sx: add desktop file and providedSessions #333678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
thiagokokada
force-pushed
the
sx-add-as-xsession
branch
2 times, most recently
from
6a41809
to
ee6d7b1
Compare
ofborg
bot
added
11.by: package-maintainer
thiagokokada
commented
Aug 10, 2024
| { | ||
| name = "sx"; | ||
| meta.maintainers = with lib.maintainers; [ | ||
| figsoda |
There was a problem hiding this comment.
@figsoda I added you as a maintainer for this test since you also are a maintainer of the module, but I can remove you if you don't want.
thiagokokada
force-pushed
the
sx-add-as-xsession
branch
from
753afaa
to
64a7c74
Compare
|
Result of 2 packages blacklisted:
1 package built:
|
thiagokokada
force-pushed
the
sx-add-as-xsession
branch
from
64a7c74
to
e3e022f
Compare
AndersonTorres
suggested changes
Aug 10, 2024
thiagokokada
force-pushed
the
sx-add-as-xsession
branch
from
e3e022f
to
863aa54
Compare
|
Result of 1 package blacklisted:
1 package built:
|
AndersonTorres
approved these changes
Aug 10, 2024
thiagokokada
force-pushed
the
sx-add-as-xsession
branch
from
863aa54
to
2c43dd5
Compare
AndersonTorres
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The changes in this PR will allow
sxto appear as a session in desktop managers, if you setservices.xserver.displayManager.sx.addAsSession = true(not enabling by default because there are some considerations, see option description). Also:services.xserver.displayManager.sx.packageoptionsxrelated files withnixpkgs-rfc-styleThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.