glew: enable both EGL and GLX #333707
Merged
glew: enable both EGL and GLX #333707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ofborg
bot
requested review from
AtilaSaraiva,
chkno,
hrdinka,
TheKostins and
fgaz
|
Can go to master |
@K900 did you test the things you mentioned were broken? I didn't white understand what, and how to test it by myself. |
|
I'm building it now. |
|
mangoapp works fine with this applied on top of latest unstable-small. |
|
Rebased and targeted master, PTAL. |
There was a problem hiding this comment.
It's sad we don't know how to reproduce the failure in a unit test, but I guess it's OK
Re-roll of NixOS#328907, but this time adding the patch from ArchLinux, which keeps both EGL and GLX code paths active. Remove overrides where EGL was explicitly requested previously, as well as the glew-egl package variant. Add an alias for glew-egl, in case there's any users of this outside of nixpkgs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-roll of #328907, but this time adding the patch from ArchLinux, which keeps both EGL and GLX code paths active.
Remove overrides where EGL was explicitly requested previously, as well as the glew-egl package variant.
I ran some games, which seemed to use the GLX path successfully, but this could get some more testing. @K900 can you check if the regressions mentioned in #328907 (comment) are working now?
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.