Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonia: 0.8.0 -> 1.0.0 #333897

Merged
merged 2 commits into from
Aug 11, 2024
Merged

harmonia: 0.8.0 -> 1.0.0 #333897

merged 2 commits into from
Aug 11, 2024

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented Aug 11, 2024

Description of changes

Reference: #332957

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove "v" from the commit message.

pkgs/by-name/ha/harmonia/package.nix Outdated Show resolved Hide resolved
@dotlambda dotlambda changed the title harmonia: v0.8.0 -> v1.0.0 harmonia: 0.8.0 -> 1.0.0 Aug 11, 2024
Co-authored-by: Robert Schütz <[email protected]>
@Mic92 Mic92 merged commit cff7476 into NixOS:master Aug 11, 2024
9 of 10 checks passed
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Aug 11, 2024
@a-kenji a-kenji deleted the update/harmonia branch August 11, 2024 17:41
@t184256
Copy link
Contributor

t184256 commented Aug 16, 2024

Was it supposed to fix #332957?

From what I see, it used to fail with

error[E0282]: type annotations needed for `Box<_>`

since 30889c3 (cargo,clippy,rustc,rustfmt: 1.79.0 -> 1.80.0),
then this PR's (cff7476 harmonia: 0.8.0 -> 1.0.0) fixed it,
but now it fails again on e402d09 (current master)
with the very same error.

I tried to bisect it and got lost in a maze of merge commits, sorry.

@a-kenji
Copy link
Contributor Author

a-kenji commented Aug 16, 2024

I assumed the release was cut to fix the time regression.
I guess it didn't make it in.

Thank you for the report @t184256, it should be fixed soon.

@Mic92
Copy link
Member

Mic92 commented Aug 16, 2024

I was too confident that dependabot would have included this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants