Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] dbeaver-bin: fix crash at startup #335921

Closed

Conversation

mausch
Copy link
Member

@mausch mausch commented Aug 19, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Fixes NixOS#330889

(cherry picked and adapted from commit da69826)
@github-actions github-actions bot added 6.topic: lib The Nixpkgs function library 6.topic: php 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) and removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: haskell 8.has: documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: policy discussion 6.topic: vim 6.topic: fetch 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: testing Tooling for automated testing of packages and modules 6.topic: systemd 6.topic: vscode 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 6.topic: php 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) labels Aug 19, 2024
@mausch
Copy link
Member Author

mausch commented Aug 19, 2024

oops, apologies if the wrong base branch notified a bunch of people :-/

@RossComputerGuy
Copy link
Member

Looks like this PR was opened on the wrong base branch. Please rebase under the right branch.

@NixOS NixOS locked and limited conversation to collaborators Aug 19, 2024
@drupol
Copy link
Contributor

drupol commented Aug 19, 2024

Why so much pings ?

@RossComputerGuy
Copy link
Member

@drupol Probably used master as the base branch when making this PR instead of the 24.05 branch.

@infinisil
Copy link
Member

I'll use one of these mass-ping PRs to mention to y'all that I've started developing a solution to the mass-ping problem: #336261

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants