Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picosnitch: mark as vulnerable #336449

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Aug 22, 2024

Description of changes

Marked as a draft for now pending upstream response to elesiuta/picosnitch#40.

cc @dali99 @jcaesar

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy added backport release-24.05 Backport PR automatically 1.severity: security Issues which raise a security issue, or PRs that fix one labels Aug 22, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 22, 2024
@SigmaSquadron SigmaSquadron added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Aug 22, 2024
@emilazy
Copy link
Member Author

emilazy commented Aug 23, 2024

I’ve sent an email to the developer as there seems to be no GitHub activity for the past several months. If we don’t hear back soon I think we should proceed with merging this.

@elesiuta
Copy link
Member

Thank you for reporting this and reaching out via email. I'm currently taking a break from working on picosnitch and am unsure if or when I'll get around to addressing everything mentioned in the issue. Please feel free to proceed with this pull request.

@emilazy
Copy link
Member Author

emilazy commented Aug 26, 2024

Thanks for the response, @elesiuta :) Taking a break is totally understandable; take care of yourself. It might be a good idea to add a warning to the README (and potentially the AUR package?) to let users of non‐NixOS distributions know about the current risks in the meantime. (I’d be happy to send a pull request for the former if it’d help, but don’t know anything about what the AUR offers for that kind of thing.)

@emilazy emilazy marked this pull request as ready for review August 26, 2024 02:36
@emilazy emilazy merged commit 0d96398 into NixOS:master Aug 27, 2024
29 of 30 checks passed
@emilazy emilazy deleted the push-vwsrpvvoyvwt branch August 27, 2024 15:30
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux backport release-24.05 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants