-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tuxedo-keyboard: fix compilation for kernel 6.10 and 6.11 #336633
Open
Keksgesicht
wants to merge
7
commits into
NixOS:master
Choose a base branch
from
Keksgesicht:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+101
−82
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7c7c77d
tuxedo-keyboard: 3.2.14 -> 4.6.2
Keksgesicht 1a22ae1
tuxedo-drivers: init at 4.6.2
Keksgesicht b0261b0
nixos/tuxedo-drivers: init
Keksgesicht 44ef829
tuxedo-drivers: 4.6.2 -> 4.7.0
Keksgesicht 629d978
maintainers: add keksgesicht
Keksgesicht 97baf37
tuxedo-drivers: add myself and a few others as maintainers
Keksgesicht c5989b0
tuxedo-drivers: update build commands
Keksgesicht File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
{ config, lib, ... }: | ||
let | ||
cfg = config.hardware.tuxedo-drivers; | ||
tuxedo-drivers = config.boot.kernelPackages.tuxedo-drivers; | ||
in | ||
{ | ||
imports = [ | ||
(lib.mkRenamedOptionModule | ||
[ | ||
"hardware" | ||
"tuxedo-keyboard" | ||
] | ||
[ | ||
"hardware" | ||
"tuxedo-drivers" | ||
] | ||
) | ||
]; | ||
|
||
options.hardware.tuxedo-drivers = { | ||
enable = lib.mkEnableOption '' | ||
The tuxedo-drivers driver enables access to the following on TUXEDO notebooks: | ||
- Driver for Fn-keys | ||
- SysFS control of brightness/color/mode for most TUXEDO keyboards | ||
- Hardware I/O driver for TUXEDO Control Center | ||
|
||
For more inforation it is best to check at the source code description: <https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers> | ||
''; | ||
}; | ||
|
||
config = lib.mkIf cfg.enable { | ||
boot.kernelModules = [ "tuxedo_keyboard" ]; | ||
boot.extraModulePackages = [ tuxedo-drivers ]; | ||
}; | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
{ | ||
lib, | ||
stdenv, | ||
fetchFromGitLab, | ||
kernel, | ||
linuxHeaders, | ||
pahole, | ||
}: | ||
|
||
stdenv.mkDerivation (finalAttrs: { | ||
pname = "tuxedo-drivers-${kernel.version}"; | ||
version = "4.7.0"; | ||
|
||
src = fetchFromGitLab { | ||
group = "tuxedocomputers"; | ||
owner = "development/packages"; | ||
repo = "tuxedo-drivers"; | ||
rev = "v${finalAttrs.version}"; | ||
hash = "sha256-wZUQHIkbxt9ckTFs8VTrA5I+ebBeaOm+Fb0+GqX5y0c="; | ||
}; | ||
|
||
buildInputs = [ | ||
pahole | ||
linuxHeaders | ||
]; | ||
|
||
makeFlags = [ "KDIR=${kernel.dev}/lib/modules/${kernel.modDirVersion}/build" ]; | ||
|
||
installPhase = '' | ||
runHook preInstall | ||
|
||
mkdir -p "$out/lib/modules/${kernel.modDirVersion}" | ||
|
||
find src/ -type f -name '*.ko' \ | ||
-exec mv {} $out/lib/modules/${kernel.modDirVersion} \; | ||
|
||
runHook postInstall | ||
''; | ||
|
||
meta = { | ||
broken = stdenv.hostPlatform.isAarch64 || (lib.versionOlder kernel.version "5.5"); | ||
description = "Keyboard and hardware I/O driver for TUXEDO Computers laptops"; | ||
homepage = "https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers"; | ||
license = lib.licenses.gpl3Plus; | ||
longDescription = '' | ||
Drivers for several platform devices for TUXEDO notebooks: | ||
- Driver for Fn-keys | ||
- SysFS control of brightness/color/mode for most TUXEDO keyboards | ||
- Hardware I/O driver for TUXEDO Control Center | ||
|
||
Can be used with the "hardware.tuxedo-drivers" NixOS module. | ||
''; | ||
maintainers = [ lib.maintainers.blanky0230 ]; | ||
platforms = lib.platforms.linux; | ||
}; | ||
}) |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Keksgesicht @CutestNekoAqua If you like, join yourselves in as maintainers. Certainly better to have a bus-factor > 1 for this package I suppose.
(I'll soon have a suitable device again too).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Keksgesicht As per #343483 ->
nixpkgs/pkgs/os-specific/linux/tuxedo-drivers/default.nix
Line 43 in 2c799a1
Also getting @xaverdh into the loop. So they know we're trying to tighten up all the various loose ends.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, whether I should add other people. But as they clearly want to develop this further, I could add them in the commit too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to add me!