Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet: remove nuget-package-hook from runtime packages #343978

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

corngood
Copy link
Contributor

@corngood corngood commented Sep 23, 2024

Description of changes

Fixes the problem described here:

#336824 (comment)

Cc: @SuperSandro2000 @NixOS/dotnet

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: dotnet Language: .NET label Sep 23, 2024
@GGG-KILLER GGG-KILLER added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 23, 2024
@corngood
Copy link
Contributor Author

Result of nixpkgs-review pr 343978 run on x86_64-linux 1

94 packages built:
  • ArchiSteamFarm
  • alttpr-opentracker
  • am2rlauncher
  • avalonia-ilspy
  • beatsabermodmanager
  • bicep
  • bililiverecorder
  • blendfarm
  • boogie
  • btcpayserver
  • btcpayserver-altcoins
  • cavalier
  • celeste64
  • certdump
  • csharprepl
  • cyclonedx-cli
  • dafny
  • denaro
  • dependency-track
  • depotdownloader
  • discordchatexporter-cli
  • dotnet-aspnetcore
  • dotnet-aspnetcore_7
  • dotnet-aspnetcore_8
  • dotnet-outdated
  • dotnet-runtime
  • dotnet-runtime_7
  • dotnet-runtime_8
  • dotnetCorePackages.aspnetcore_9_0
  • dotnetCorePackages.dotnet_8.aspnetcore
  • dotnetCorePackages.dotnet_8.runtime
  • dotnetCorePackages.dotnet_9.aspnetcore
  • dotnetCorePackages.dotnet_9.runtime
  • dotnetCorePackages.runtime_9_0
  • eventstore
  • famistudio
  • formula
  • galaxy-buds-client
  • garnet
  • gh-gei
  • git-credential-manager
  • github-runner
  • ilspycmd
  • inklecate
  • jackett
  • jellyfin
  • juniper
  • kavita
  • knossosnet
  • kryptor
  • libation
  • lidarr
  • lubelogger
  • lumafly
  • marksman
  • mqttmultimeter
  • msbuild
  • naps2
  • nbxplorer
  • netcoredbg
  • networkminer
  • nexusmods-app
  • nexusmods-app-unfree
  • openra
  • opentabletdriver
  • openutau
  • osu-lazer
  • pablodraw
  • parabolic
  • pinta
  • prowlarr
  • ps3-disc-dumper
  • pupdate
  • radarr
  • readarr
  • recyclarr
  • renode
  • renode-unstable
  • retrospy
  • roslyn
  • ryujinx
  • scarab
  • slskd
  • sonarr
  • space-station-14-launcher
  • tagger
  • technitium-dns-server
  • tone
  • torrentstream
  • vintagestory
  • vrcadvert
  • wasabibackend
  • wiseunpacker
  • xivlauncher

@SuperSandro2000
Copy link
Member

Diff on my system:

nuget-package: ε → ∅
perl5.38.2-Archive-Cpio: 0.10 → ∅, -22.3 KiB
perl5.38.2-Archive-Zip: 1.68 → ∅, -219.4 KiB
perl5.38.2-SUPER: 1.20190531 → ∅, -9.3 KiB
perl5.38.2-Test-MockModule: 0.177.0 → ∅, -18.5 KiB
perl5.38.2-strip-nondeterminism: 1.13.1 → ∅, -90.1 KiB
xmlstarlet: 1.6.1 → ∅, -211.5 KiB
zip: 3.0 → ∅, -590.2 KiB

👍🏼 thanks

@corngood corngood merged commit 0851332 into NixOS:master Sep 23, 2024
43 checks passed
@corngood corngood deleted the remove-nuget-package-hook branch September 23, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: dotnet Language: .NET 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants