lavalink: init at 4.0.8; nixos/lavalink: init #344687
Open
+477
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
NixOSInfra
added
the
12. first-time contribution
nanoyaki
force-pushed
the
lavalink
branch
2 times, most recently
from
ba653a0
to
cbb5a8d
Compare
ofborg
bot
added
8.has: package (new)
Bot-wxt1221
reviewed
Sep 27, 2024
Bot-wxt1221
reviewed
Sep 27, 2024
|
I haven't check the nixos module. |
nanoyaki
changed the title
nanoyaki
force-pushed
the
lavalink
branch
2 times, most recently
from
1b5659e
to
2a04599
Compare
|
I addressed all of the above in the recent pushes |
Bot-wxt1221
reviewed
Sep 27, 2024
Bot-wxt1221
reviewed
Sep 27, 2024
pkgs/by-name/la/lavalink/package.nix
Outdated
| ]; | ||
|
|
||
| buildInputs = [ | ||
| systemd |
There was a problem hiding this comment.
That was due to this warning during runtime:
o.s.os.linux.LinuxOperatingSystem : Did not find udev library in operating system. Some features may not work.
I just tested it again and it doesn't seem to have fixed the issue.
I'm not sure how to solve this issue.
I tried installing libudev using
(systemd.override {
buildLibsOnly = true;
})and systemdLibs but neither seem to work.
Bot-wxt1221
reviewed
Sep 27, 2024
h7x4
added
8.has: module (new)
I've seen other packages with the same approach, so I'm not sure to why? |
|
@nanoyaki According to manual, we'd better build from source. But now it's ok if you don't want to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
A standalone audio sending node based on Lavaplayer and Koe.
This adds the package for Lavalink and a corresponding nixos module.
I tested the program with and without plugins and several different configurations on my local computer, and a remote nixos machine.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.