Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.tests: remove unnecessary condition and disable failing tests on 3.13 #347206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −17
Open

python3.tests: remove unnecessary condition and disable failing tests on 3.13 #347206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 19 additions & 17 deletions pkgs/development/interpreters/python/tests.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ let
is_virtualenv = "False";
};

} // lib.optionalAttrs (python.pythonAtLeast "3.8") {
} // {
# Venv built using Python Nix environment (python.buildEnv)
# TODO: Cannot create venv from a nix env
# Error: Command '['/nix/store/ddc8nqx73pda86ibvhzdmvdsqmwnbjf7-python3-3.7.6-venv/bin/python3.7', '-Im', 'ensurepip', '--upgrade', '--default-pip']' returned non-zero exit status 1.
Expand Down Expand Up @@ -105,22 +105,24 @@ let

# Integration tests involving the package set.
# All PyPy package builds are broken at the moment
integrationTests = lib.optionalAttrs (!python.isPyPy) (
lib.optionalAttrs (python.isPy3k && !stdenv.hostPlatform.isDarwin) { # darwin has no split-debug
cpython-gdb = callPackage ./tests/test_cpython_gdb {
interpreter = python;
};
} // lib.optionalAttrs (python.pythonAtLeast "3.7") {
# Before the addition of NIX_PYTHONPREFIX mypy was broken with typed packages
nix-pythonprefix-mypy = callPackage ./tests/test_nix_pythonprefix {
interpreter = python;
};
# Make sure tkinter is importable. See https://github.com/NixOS/nixpkgs/issues/238990
tkinter = callPackage ./tests/test_tkinter {
interpreter = python;
};
}
);
integrationTests = lib.optionalAttrs (!python.isPyPy) ({
# Make sure tkinter is importable. See https://github.com/NixOS/nixpkgs/issues/238990
tkinter = callPackage ./tests/test_tkinter {
interpreter = python;
};
} // lib.optionalAttrs (python.isPy3k && python.pythonOlder "3.13" && !stdenv.hostPlatform.isDarwin) { # darwin has no split-debug
# fails on python3.13
cpython-gdb = callPackage ./tests/test_cpython_gdb {
interpreter = python;
};
} // lib.optionalAttrs (python.isPy3k && python.pythonOlder "3.13") {
# Before the addition of NIX_PYTHONPREFIX mypy was broken with typed packages
# mypy does not yet support python3.13
# https://github.com/python/mypy/issues/17264
nix-pythonprefix-mypy = callPackage ./tests/test_nix_pythonprefix {
interpreter = python;
};
});

# Test editable package support
editableTests = let
Expand Down