Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.imgtool: remove #347346

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Oct 8, 2024

This is already packaged as a proper Python application in mcuboot-imgtool. An alias redirects existing users.


Add a 👍 reaction to pull requests you find important.

pkgs/by-name/im/imgtool/package.nix Outdated Show resolved Hide resolved
@samueltardieu samueltardieu force-pushed the push-wmonqkukvwqy branch 2 times, most recently from b95b61b to e1559f1 Compare October 8, 2024 21:06
@samueltardieu

This comment was marked as resolved.

@infinisil

This comment was marked as resolved.

@samueltardieu

This comment was marked as resolved.

@SuperSandro2000
Copy link
Member

Please don't clear the template

@SuperSandro2000
Copy link
Member

You are effectively removing the package from python3Packages. We should probably add an alias for that.

@samueltardieu samueltardieu changed the title imgtool: move to by-name imgtool: remove Oct 8, 2024
@samueltardieu
Copy link
Contributor Author

You are effectively removing the package from python3Packages. We should probably add an alias for that.

Yes, the package is in fact an application (and should not have been put into python3Packages), and is already available as mcuboot-imgtool (which had been accepted in 2023 a few days before this package).

Nobody depends on imgtool in nixpkgs. Some people might have installed it, for example using home-manager. Is there a procedure to migrate to mcuboot-imgtool for them?

Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the packages are indeed identical, make an alias attribute that points to mcuboot-imgtool.

@samueltardieu
Copy link
Contributor Author

If the packages are indeed identical, make an alias attribute that points to mcuboot-imgtool.

Done.

@SigmaSquadron SigmaSquadron added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 8, 2024
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Oct 8, 2024
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message and the PR title should start with python312Packages.imgtool since this is in the python modules.

pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
@samueltardieu
Copy link
Contributor Author

The commit message and the PR title should start with python312Packages.imgtool since this is in the python modules.

Done.

@nix-owners nix-owners bot requested a review from natsukium October 9, 2024 07:16
This is already packaged as a proper Python application in
mcuboot-imgtool. An alias redirects existing users.
@samueltardieu samueltardieu changed the title imgtool: remove python312Packages.imgtool: remove Oct 9, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 9, 2024
@samueltardieu
Copy link
Contributor Author

@natsukium I've made the requested changes, and ofborg run is clean

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4691

@SuperSandro2000 SuperSandro2000 merged commit a415667 into NixOS:master Oct 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants