-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.imgtool: remove #347346
Conversation
c6e975e
to
05acd0b
Compare
b95b61b
to
e1559f1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
e1559f1
to
1dc1fcc
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Please don't clear the template |
You are effectively removing the package from python3Packages. We should probably add an alias for that. |
1dc1fcc
to
6d5c063
Compare
Yes, the package is in fact an application (and should not have been put into python3Packages), and is already available as mcuboot-imgtool (which had been accepted in 2023 a few days before this package). Nobody depends on imgtool in nixpkgs. Some people might have installed it, for example using home-manager. Is there a procedure to migrate to mcuboot-imgtool for them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the packages are indeed identical, make an alias attribute that points to mcuboot-imgtool
.
6d5c063
to
37fba72
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message and the PR title should start with python312Packages.imgtool
since this is in the python modules.
37fba72
to
701f429
Compare
Done. |
This is already packaged as a proper Python application in mcuboot-imgtool. An alias redirects existing users.
701f429
to
8c78777
Compare
@natsukium I've made the requested changes, and ofborg run is clean |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4691 |
This is already packaged as a proper Python application in mcuboot-imgtool. An alias redirects existing users.
Add a 👍 reaction to pull requests you find important.