-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No more mass pings due to the wrong base branch [skip treewide] #347626
Conversation
The PR's base branch is set to master, but 1108 commits from the staging branch are included. Make sure you know the right base branch for your changes, then:
|
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
LGTM |
On a serious note, awesome to see it worked! |
Please fix the |
LGTM (looks gore to me) |
d55640f
to
6e1decb
Compare
diff --git a/.editorconfig b/.editorconfig index 1d2259154e48..60f8659fdf79 100644 --- a/.editorconfig +++ b/.editorconfig @@ -6,7 +6,7 @@ root = true # Unix-style newlines with a newline ending every file, utf-8 charset [*] -end_of_line = lf +end_of_line = crlf insert_final_newline = true trim_trailing_whitespace = true charset = utf-8
6e1decb
to
c061569
Compare
The PR's base branch is set to staging, but 15 commits from the master branch are included. Make sure you know the right base branch for your changes, then:
|
Turns out it's not possible to request more than 15 people with normal means, so it's very much impossible to mass ping people now! This isn't great though, it's fair to mass ping if the relevant files are changed legitimately, so I'll look into how this can be addressed. To avoid further notifications, let's close and lock this now though |
This is an intentional final mass ping to make a PSA to everybody who's been plagued by unnecessary mass pings for all these years, because it won't happen any longer!
This is because since recently, we're not using the GitHub-native
CODEOWNERS
file, but rather the customci/OWNERS
and a smart GitHub Action workflow to check it and request reviews based on it, with the major benefits of:Please spread the news that we can freely set and change the base branch now without worrying about filling up notification inboxes, and encourage more people to add themselves as code owners 🚀
And if you spot any issues, let me know, I'll be tending to it
Original description:
Add support for Windows by changing all files to use CRLF as the file ending. Who knew it would be this simple!
This was sponsored by Antithesis and Tweag! ✨