-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/actual: init at 24.10.1 #347825
Open
oddlama
wants to merge
3
commits into
NixOS:master
Choose a base branch
from
oddlama:feat-actual-budget
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
nixos/actual: init at 24.10.1 #347825
+262
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: documentation
8.has: changelog
8.has: module (update)
This PR changes an existing module in `nixos/`
labels
Oct 11, 2024
oddlama
changed the title
nixos/actual-budget: init at 24.10.1
nixos/actual: init at 24.10.1
Oct 11, 2024
oddlama
force-pushed
the
feat-actual-budget
branch
from
October 11, 2024 01:20
0503788
to
4590c78
Compare
ofborg
bot
added
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild
10.rebuild-linux: 1-10
labels
Oct 11, 2024
h7x4
added
8.has: module (new)
This PR adds a module in `nixos/`
8.has: tests
This PR has tests
labels
Oct 11, 2024
PatrickDaG
suggested changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Thx for finishing the module.
oddlama
force-pushed
the
feat-actual-budget
branch
from
October 11, 2024 12:40
4590c78
to
91adb3e
Compare
Fair points, all comments were addressed |
PatrickDaG
approved these changes
Oct 11, 2024
wegank
added
12.approvals: 1
This PR was reviewed and approved by one reputable person
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
labels
Oct 15, 2024
jdheyburn
reviewed
Oct 24, 2024
oddlama
force-pushed
the
feat-actual-budget
branch
from
October 24, 2024 19:24
91adb3e
to
78d7057
Compare
wegank
removed
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
12.approvals: 1
This PR was reviewed and approved by one reputable person
labels
Oct 29, 2024
diff --git a/pkgs/by-name/ac/actual-server/package.nix b/pkgs/by-name/ac/actual-server/package.nix
index c2daf4ea2060..c3284a8e3381 100644
--- a/pkgs/by-name/ac/actual-server/package.nix
+++ b/pkgs/by-name/ac/actual-server/package.nix
@@ -9,14 +9,15 @@
nodejs,
yarn,
nixosTests,
+ nix-update-script,
}:
let
- version = "24.10.1";
+ version = "24.11.0";
src = fetchFromGitHub {
owner = "actualbudget";
repo = "actual-server";
rev = "v${version}";
- hash = "sha256-VJAD+lNamwuYmiPJLXkum6piGi5zLOHBp8cUeZagb4s=";
+ hash = "sha256-tEanuY2GRufLbyjkhwFcsn8Nl3wlf/PbVJjzJfTTk7g=";
};
# We cannot use fetchYarnDeps because that doesn't support yarn2/berry
@@ -72,7 +73,7 @@ let
outputHashAlgo = "sha256";
outputHashMode = "recursive";
- outputHash = "sha256-eNpOS21pkamugoYVhzsEnstxeVN/J06yDZcshfr0Ek4=";
+ outputHash = "sha256-yda1GdnPRHOoaJzkGz755Lm9/J60lFDsVvBgf/2e+3I=";
};
in
stdenv.mkDerivation {
@@ -101,6 +102,7 @@ stdenv.mkDerivation {
passthru = {
inherit offlineCache;
tests = nixosTests.actual;
+ passthru.updateScript = nix-update-script { };
};
meta = { |
Co-authored-by: PatrickDaG <[email protected]>
Co-authored-by: PatrickDaG <[email protected]>
oddlama
force-pushed
the
feat-actual-budget
branch
from
November 3, 2024 16:47
78d7057
to
ea062fb
Compare
ofborg
bot
added
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild
labels
Nov 4, 2024
MangoIV
reviewed
Nov 7, 2024
Co-authored-by: Mango The Fourth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: changelog
8.has: documentation
8.has: module (new)
This PR adds a module in `nixos/`
8.has: module (update)
This PR changes an existing module in `nixos/`
8.has: package (new)
This PR adds a new package
8.has: tests
This PR has tests
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a package, module and basic test for Actual, a privacy-focused app for managing finances. Closes #269069.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.