-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marimo: 0.9.1 -> 0.9.9 #348012
marimo: 0.9.1 -> 0.9.9 #348012
Conversation
a847874
to
fd7c4c7
Compare
fd7c4c7
to
61da64d
Compare
|
61da64d
to
99c5c62
Compare
Thanks, was a little behind head. |
]; | ||
|
||
pythonImportsCheck = [ "narwhals" ]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you enable tests with pytestCheckHook
?
hash = "sha256-Wz9SwCqGcwphFJfm/7rMqj34b8JkcMI+P7QNwrx5Prs="; | ||
}; | ||
|
||
nativeBuildInputs = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nativeBuildInputs = [ | |
build-system = [ |
}; | ||
|
||
build-system = [ setuptools ]; | ||
nativeBuildInputs = [ hatchling ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nativeBuildInputs = [ hatchling ]; | |
build-system = [ hatchling ]; |
hatchling, | ||
}: | ||
let | ||
pname = "narwhals"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
narwhals
is in already in staging
(6432b6e).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR now conflicts with master
]; | ||
|
||
nativeCheckInputs = [ pytestCheckHook ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the tests are exclude then an option would be to use the source from GitHub. Persuade upstream to include the tests in PyPI releases usually takes some time.
I missed this PR and opened #353022.
Feel free to take my changes if you want, or we can also merge #353022 directly, as you prefer. |
Closed out for the new PR. |
Added narwhals at 1.9.7
Updated marimo build system to hatch + deps + version
Removed tests because it was a noop (tests are not included in pypi)
Built on platform(s)
For non-Linux: Is sandboxing enabled in
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
Tested, as applicable:
Tested compilation of all packages that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usageTested basic functionality of all binary files (usually in
./result/bin/
)24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
Fits CONTRIBUTING.md.
Add a 👍 reaction to pull requests you find important.