Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/languages-frameworks/gnome: update Qt package example #348646

Merged

Conversation

tomodachi94
Copy link
Member

Part of #180841

Updated the existing example to reflect changes from a later version of
the same package:
https://github.com/NixOS/nixpkgs/blob/b293f6561ea74ccd9ddafe49f8227caf5b85f720/pkgs/applications/misc/calibre/default.nix

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tomodachi94
Copy link
Member Author

Part of #253291 perhaps

@tomodachi94
Copy link
Member Author

Requesting a review from @jtojnar, who appears to be the primary person to make changes to this manual page nowadays.

@tomodachi94 tomodachi94 force-pushed the enhance/doc/gnome/replace-outdated-example branch from 34f1d47 to b75d1e4 Compare October 19, 2024 03:41
@tomodachi94 tomodachi94 force-pushed the enhance/doc/gnome/replace-outdated-example branch from b75d1e4 to 6253446 Compare October 19, 2024 04:00
@tomodachi94 tomodachi94 force-pushed the enhance/doc/gnome/replace-outdated-example branch from 6253446 to e4248a8 Compare October 19, 2024 04:02
@Aleksanaa Aleksanaa merged commit 8474a26 into NixOS:master Oct 19, 2024
25 checks passed
@tomodachi94 tomodachi94 deleted the enhance/doc/gnome/replace-outdated-example branch October 19, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants