-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
babelstone-han: 13.0.3 -> 16.0.2 #348730
base: master
Are you sure you want to change the base?
babelstone-han: 13.0.3 -> 16.0.2 #348730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! The diff looks good to me except for needing a more permanent URL. The other commits will need squashing into the first one; if you’d like to be a maintainer of the package you’ll need to add yourself to maintainers/maintainer-list.nix
in another commit first.
|
||
src = fetchzip { | ||
# upstream download links are unversioned, so hash changes | ||
url = "https://web.archive.org/web/20200210125314/https://www.babelstone.co.uk/Fonts/Download/BabelStoneHan.zip"; | ||
hash = "sha256-LLhNtHu2hh5DY2XVSrLuVzzR6OtMdSSHetyA0k1IFs0="; | ||
url = "https://www.babelstone.co.uk/Fonts/Download/BabelStoneHan.zip"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We historically had to use an archive link here since the URL is unstable. It looks like upstream now has versioned URLs like https://www.babelstone.co.uk/Fonts/Download/BabelStoneHan-16.0.2.zip, but that only the last two versions are kept. So I think we should still probably wait a little bit here for the Wayback Machine to stop being read‐only to use an archived link again here.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.