Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fahrplan: init at 1.1.2 #349904

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fahrplan: init at 1.1.2 #349904

merged 1 commit into from
Nov 6, 2024
+36 −0

Conversation

p-h
Copy link
Contributor

@p-h p-h commented Oct 20, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

dotlambda
dotlambda reviewed Oct 20, 2024
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixfmt

pkgs/by-name/fa/fahrplan/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fa/fahrplan/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fa/fahrplan/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fa/fahrplan/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fa/fahrplan/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fa/fahrplan/package.nix Outdated Show resolved Hide resolved
@p-h p-h force-pushed the add-fahrplan branch 2 times, most recently from 58c1311 to 922ef10 Compare October 20, 2024 03:35
@p-h p-h requested a review from dotlambda October 20, 2024 03:35
@p-h p-h force-pushed the add-fahrplan branch 2 times, most recently from 95d5022 to e9edbe2 Compare October 20, 2024 04:16
@p-h p-h requested a review from dotlambda October 20, 2024 23:59
@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 2, 2024
@Aleksanaa Aleksanaa merged commit 35d1e72 into NixOS:master Nov 6, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@p-h @dotlambda @FliegendeWurst @Aleksanaa