Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{shoko-webui,shokoserver,nixos/shokoserver}: init #350065

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

{shoko-webui,shokoserver,nixos/shokoserver}: init #350065

wants to merge 3 commits into from

Conversation

diniamo
Copy link
Contributor

@diniamo diniamo commented Oct 20, 2024

Adds a NixOS module for https://github.com/ShokoAnime/ShokoServer, along with derivations for the module's dependencies.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 20, 2024
@diniamo
Copy link
Contributor Author

diniamo commented Oct 20, 2024

The formatting check fails for the generated dependencies file, which I don't believe should be formatted.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 20, 2024
@diniamo diniamo force-pushed the shokoanime branch 3 times, most recently from e68ce8a to 001d025 Compare October 21, 2024 14:45
@h7x4 h7x4 added 8.has: tests This PR has tests 8.has: module (new) This PR adds a module in `nixos/` labels Oct 22, 2024
@diniamo diniamo force-pushed the shokoanime branch 6 times, most recently from fdc24a7 to 9df8fbd Compare October 29, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diniamo @h7x4