Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-uml: fix build #350201

Merged
merged 2 commits into from
Oct 22, 2024
Merged

clang-uml: fix build #350201

merged 2 commits into from
Oct 22, 2024

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Oct 21, 2024 •
edited
Loading

https://hydra.nixos.org/build/274975566/nixlog/1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Bot-wxt1221
Copy link
Member Author

I'm building.

@Bot-wxt1221 Bot-wxt1221 marked this pull request as draft October 21, 2024 10:08
@Bot-wxt1221 Bot-wxt1221 marked this pull request as ready for review October 21, 2024 10:31
@Bot-wxt1221
Copy link
Member Author

@kirillrdy Done.

zi3m5f
zi3m5f reviewed Oct 21, 2024
View reviewed changes
pkgs/by-name/cl/clang-uml/package.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from hatch01 October 21, 2024 12:18
hatch01
hatch01 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@hatch01 hatch01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

pkgs/by-name/cl/clang-uml/package.nix Show resolved Hide resolved
zi3m5f
zi3m5f approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@zi3m5f zi3m5f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350201

x86_64-linux

✅ 1 package built:
  • clang-uml

@zi3m5f
Copy link
Contributor

zi3m5f commented Oct 22, 2024

Somthing I noticed:

$ results/clang-uml-x86_64-linux/bin/clang-uml --version
> clang-uml 0.0.0-unknown

and found out one can maybe fix it with GIT_VERSION:
bkryza/clang-uml#211

But it can be done in a later PR, ideally in combination with versionCheckHook and testers.testVersion ;)

@kirillrdy kirillrdy merged commit f8e00f2 into NixOS:master Oct 22, 2024
27 of 28 checks passed
@zi3m5f zi3m5f mentioned this pull request Oct 22, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillrdy kirillrdy kirillrdy left review comments

@zi3m5f zi3m5f zi3m5f approved these changes

@hatch01 hatch01 hatch01 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bot-wxt1221 @zi3m5f @kirillrdy @hatch01