Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions.sainnhe.gruvbox-material: init at 6.5.2 #350464

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

vscode-extensions.sainnhe.gruvbox-material: init at 6.5.2 #350464

wants to merge 2 commits into from

Conversation

thtrf
Copy link
Contributor

@thtrf thtrf commented Oct 22, 2024 •
edited by dotlambda
Loading

fixes #325345

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@thtrf thtrf marked this pull request as ready for review October 22, 2024 11:38
@thtrf thtrf mentioned this pull request Oct 22, 2024
Open
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 22, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 31, 2024
dotlambda
dotlambda reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta.changelog and meta.maintainers missing

pkgs/applications/editors/vscode/extensions/default.nix Outdated Show resolved Hide resolved
@thtrf thtrf force-pushed the init-vscode-sainnhe.gruvbox-material branch 2 times, most recently from 95fd61a to f082e00 Compare November 1, 2024 08:58
@thtrf
Copy link
Contributor Author

thtrf commented Nov 1, 2024

meta.changelog and meta.maintainers missing

I added meta.changelog, but meta.maintainers is optional.

@thtrf thtrf requested a review from dotlambda November 1, 2024 09:02
@dotlambda
Copy link
Member

but meta.maintainers is optional

I disagree with the README on that, see pkgs/README.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild labels Nov 1, 2024
@thtrf
Copy link
Contributor Author

thtrf commented Nov 1, 2024

but meta.maintainers is optional

I disagree with the README on that, see pkgs/README.md.

Don't you think it's a bit overkill for a vscode theme?

@dotlambda
Copy link
Member

Don't you think it's a bit overkill for a vscode theme?

No. It's very useful to have @r-ryantm ping a maintainer who can approve the PR.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 1, 2024
@thtrf thtrf marked this pull request as draft November 1, 2024 20:14
@thtrf thtrf force-pushed the init-vscode-sainnhe.gruvbox-material branch from f082e00 to ee7934a Compare November 1, 2024 20:14
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 1, 2024
@thtrf thtrf force-pushed the init-vscode-sainnhe.gruvbox-material branch from ee7934a to c952a4b Compare November 1, 2024 20:17
@thtrf thtrf marked this pull request as ready for review November 1, 2024 20:18
@thtrf
Copy link
Contributor Author

thtrf commented Nov 1, 2024 •
edited
Loading

No. It's very useful to have @r-ryantm ping a maintainer who can approve the PR.

I have now added myself as a maintainer. Why are the README files so inconsistent?

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Nov 2, 2024
@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: vscode 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: vscode-extensions.sainnhe.gruvbox-material-vscode
4 participants
@thtrf @dotlambda @FliegendeWurst @wegank