Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloudPackages.apps.files_mindmap: init at 0.0.30 #350493

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

onny
Copy link
Contributor

@onny onny commented Oct 22, 2024

Adding files_mindmap to the Nextcloud packages set, „enables Nextcloud users to open, save and edit mind map files in the web browser“.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@zi3m5f
Copy link
Contributor

zi3m5f commented Oct 22, 2024

Your PR only mentions the addition but there are updates too. Your commit, title is too long by the way, should be split:

- Create a commit for each logical unit.

and the updates should be mentioned in the PR.
And why only for 28.json?

@onny
Copy link
Contributor Author

onny commented Oct 22, 2024

Currently the app is only available for Nextcloud 28

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Oct 22, 2024
@@ -8,6 +8,7 @@
, "end_to_end_encryption": "agpl3Plus"
, "files_texteditor": "agpl3Plus"
, "files_markdown": "agpl3Plus"
, "files_mindmap": "agpl3Only"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened an upstream issue about this ACTom/files_mindmap#205

And changed it to AGPL3Plus for now

@happysalada happysalada merged commit 79ab168 into NixOS:master Nov 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants