lora: init at v3.005 #350536
Merged
lora: init at v3.005 #350536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
SuperSandro2000
force-pushed
the
lora-init
branch
from
9d6b559
to
ffdf1ac
Compare
nyabinary
reviewed
Oct 27, 2024
| nix-update-script, | ||
| }: | ||
|
|
||
| stdenvNoCC.mkDerivation rec { |
There was a problem hiding this comment.
Suggested change
| stdenvNoCC.mkDerivation rec { | |
| stdenvNoCC.mkDerivation (finalAttrs: { |
| src = fetchFromGitHub { | ||
| owner = "cyrealtype"; | ||
| repo = "lora"; | ||
| rev = version; |
There was a problem hiding this comment.
Suggested change
| rev = version; | |
| rev = finalAttrs.version; |
| platforms = platforms.all; | ||
| maintainers = with maintainers; [ ofalvai ]; | ||
| }; | ||
| } |
There was a problem hiding this comment.
| runHook postInstall | ||
| ''; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| meta = { |
| meta = with lib; { | ||
| description = "Lora is a well-balanced contemporary serif with roots in calligraphy"; | ||
| homepage = "https://github.com/cyrealtype/lora"; | ||
| license = licenses.ofl; |
There was a problem hiding this comment.
Suggested change
| license = licenses.ofl; | |
| license = lib.licenses.ofl; |
| description = "Lora is a well-balanced contemporary serif with roots in calligraphy"; | ||
| homepage = "https://github.com/cyrealtype/lora"; | ||
| license = licenses.ofl; | ||
| platforms = platforms.all; |
There was a problem hiding this comment.
Suggested change
| platforms = platforms.all; | |
| platforms = lib.platforms.all; |
| homepage = "https://github.com/cyrealtype/lora"; | ||
| license = licenses.ofl; | ||
| platforms = platforms.all; | ||
| maintainers = with maintainers; [ ofalvai ]; |
There was a problem hiding this comment.
Suggested change
| maintainers = with maintainers; [ ofalvai ]; | |
| maintainers = with lib.maintainers; [ ofalvai ]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.