Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

junest: fix --version flag #350561

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

jdev082
Copy link

@jdev082 jdev082 commented Oct 22, 2024

This pull request adds the file VERSION from the source code to the package so that the $ junest --version works properly.

Before this fix:

$ junest --version

cat: /nix/store/4gxxgvh6w7kvzmf75jfdxhaj9lpvg4vr-junest-7.4.9/VERSION: No such file or directory
JuNest 

After this fix

$ junest --version

JuNest 7.4.10

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 22, 2024
@Aleksanaa
Copy link
Member

Would be better to substitute https://github.com/fsquillace/junest/blob/0037f96e159a143e37db978e537e3fb362ba3a5b/bin/junest#L81 instead, since it's not a really good practice to add more nonstandard locations. Also installPhase lacks preInstall and postInstall.

Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@jdev082 jdev082 force-pushed the junest-fixversionflag branch from dc8f1e8 to beef8d4 Compare October 29, 2024 21:08
@jdev082
Copy link
Author

jdev082 commented Oct 29, 2024

Would be better to substitute https://github.com/fsquillace/junest/blob/0037f96e159a143e37db978e537e3fb362ba3a5b/bin/junest#L81 instead, since it's not a really good practice to add more nonstandard locations. Also installPhase lacks preInstall and postInstall.

I opted to replace the cat command entirely with the package version. I added both the preInstall and postInstall hooks (I'm assuming that's what you meant).

@jdev082 jdev082 force-pushed the junest-fixversionflag branch from 74ab68e to 5db2933 Compare October 29, 2024 21:12
@jdev082 jdev082 force-pushed the junest-fixversionflag branch from 85e5b14 to 0f4ede2 Compare October 29, 2024 21:17
@jdev082 jdev082 requested a review from Aleksanaa October 29, 2024 21:19
substituteInPlace $out/lib/core/common.sh --replace-fail "wget" ${lib.getExe wget}

runHook postInstall
'';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bonus: to test --version works correctly, add a https://nixos.org/manual/nixpkgs/unstable/#versioncheckhook

@Aleksanaa Aleksanaa changed the title junest: include VERSION file in the package so --version works properly junest: fix --version flag Nov 6, 2024
@Aleksanaa Aleksanaa merged commit 0bf659f into NixOS:master Nov 6, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants