-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsme-test: init at unstable-2022-12-07 #351062
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some general suggestions. Unfortunately I can't test the module.
Thanks for the suggestions and fixes @zi3m5f @FliegendeWurst, I've included them all in this new revision <3 edit: fixed the commit and PR titles as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Checked
githubId
I think the package name should contain tsme
to be easier to find.
@zi3m5f thanks for the other suggestions, implemented them as well. Package is now renamed to tsme-test, in case AMD decides to add separate modules/tools for other memory-encryption systems we have to change the name back but considering the fact they haven't added any other modules in years... INSTALL_MOD_PATH was left over from an old version and does nothing, apologies for not noticing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM :)
Build with latest kernel and checked with modinfo
:
filename: result/lib/modules/6.11.5/extra/tsme-test.ko
description: TSME test module
license: GPL
author: Advanced Micro Devices, Inc.
depends:
retpoline: Y
name: tsme_test
vermagic: 6.11.5 SMP preempt mod_unload
parm: debug: print extra debug information - any non-zero value (uint)
Things done
Add https://github.com/AMDESE/mem-encryption-tests to nixpkgs. This adds a kernel module that allows to check whether TSME is enabled and working as intended on supported systems while booted.
Note: Testing this requires an supported AMD CPU and supported BIOS. For testing, please load the kernel module and check whether /sys/kernel/tsme exists.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.