Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{bintools-wrapper,cc-wrapper}: factor out Darwin SDK logic, allow paths relative to the Darwin SDK #351315

Merged
merged 2 commits into from
Oct 26, 2024
Merged

{bintools-wrapper,cc-wrapper}: factor out Darwin SDK logic, allow paths relative to the Darwin SDK #351315

merged 2 commits into from
Oct 26, 2024

Commits on Oct 26, 2024

  1. {bintools-wrapper,cc-wrapper}: factor out Darwin SDK logic 

    This reduces code duplication, makes the SDK variables available
earlier in the wrappers, and makes the behaviour between the two
wrappers more consistent.
    @emilazy
    emilazy committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    9142a07 View commit details
    Browse the repository at this point in the history

  2. {bintools-wrapper,cc-wrapper}: allow paths relative to the Darwin SDK 

    `-L` and `-I` are interpreted relative to the `$SDKROOT` by the
Darwin toolchain, so we have to avoid filtering out such paths in the
purity filter hacks in order to not break e.g. the .NET Core build
system. It’s also just the correct thing to do for the platform.
    @emilazy
    emilazy committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    e047c69 View commit details
    Browse the repository at this point in the history