libticonv: link with libiconv #351407
Merged
libticonv: link with libiconv #351407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paparodeo
changed the title
paparodeo
force-pushed
the
libticonv-link-iconv
branch
from
417212e
to
5a04634
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 0
the darwin sdk rework removed the libiconv hook which adds -liconv so add explicitly to work around broken autoconf libiconv detection
paparodeo
force-pushed
the
libticonv-link-iconv
branch
from
5a04634
to
64efe2b
Compare
emilazy
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the darwin sdk rework removed the libiconv hook which adds -liconv so add explicitly to work around broken autoconf libiconv detection
https://hydra.nixos.org/build/276186521
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.