Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: split man into man output, add documentation as doc #351724

Merged
merged 1 commit into from
Oct 29, 2024
Merged

sqlite: split man into man output, add documentation as doc #351724

merged 1 commit into from
Oct 29, 2024

Conversation

Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Oct 27, 2024 •
edited
Loading

The full sqlite documentation is now available in the doc output, and the manual is in man.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Profpatsch Profpatsch requested review from rhelmot and np October 27, 2024 18:07
@rhelmot
Copy link
Contributor

rhelmot commented Oct 28, 2024

though given the rebuild numbers it should probably target staging...

@Profpatsch
Copy link
Member Author

Will do

@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: qt/kde 8.has: documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: printing 6.topic: rust 6.topic: policy discussion 6.topic: golang 6.topic: ruby 6.topic: vim 6.topic: stdenv Standard environment 6.topic: nodejs labels Oct 28, 2024
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: qt/kde 8.has: documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: printing 6.topic: rust 6.topic: policy discussion 6.topic: golang 6.topic: ruby 6.topic: vim 6.topic: stdenv Standard environment 6.topic: nodejs 6.topic: cinnamon Desktop environment 6.topic: systemd 6.topic: vscode 6.topic: lib The Nixpkgs function library 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: php 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: flutter labels Oct 28, 2024
@Profpatsch
Copy link
Member Author

HOW DOES THIS STILL HAPPEN ARGH

Okay rebased on staging, but I probably screwed it up

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 28, 2024
@Profpatsch
Copy link
Member Author

Merge conflict with what?

@Profpatsch @SuperSandro2000
sqlite: split man into man output, add documentation as doc
83d5162 
The full sqlite documentation is now available in the `doc` output,
and the manual is in `man`.
@Profpatsch Profpatsch merged commit 629cfe1 into NixOS:staging Oct 29, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa left review comments

@rhelmot rhelmot rhelmot approved these changes

@np np Awaiting requested review from np

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Profpatsch @rhelmot @Aleksanaa