swaylock-plugin: init at 1.8.0

[picnoir]

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[picnoir]

Opened a PR upstream to fix the maybe-unitialized GCC error there: mstoeckl/swaylock-plugin#14

[katexochen]

Tested this in my config and it works fine.

[picnoir]

Upstream merged the above PR, I'm considering pointing to the current main HEAD instead of the latest release 🤔

WDYT?

[zi3m5f]

I would use patches to apply the specify commit only using fetchpatch and:
https://github.com/mstoeckl/swaylock-plugin/commit/337a6a31dc354426ebf32e31ded56a7e5d350c7a.patch

[zi3m5f]

I spotted the completions being installed in the wrong place?

For example bash:
share/bash-completion/completions/bash/swaylock-plugin
instead of
share/bash-completion/completions/swaylock-plugin

maybe just fix it in postInstall or better fix it upstream? ;)

Upstream line at fault?
https://github.com/mstoeckl/swaylock-plugin/blob/00e4f9336df974a4319592afa5a9b1ee90cfd5ca/completions/meson.build#L19

Also not required but maybe you would be willing to add versionCheckHook or testers.testVersion?

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352330

---

x86_64-linux

✅ 1 package built:

• swaylock-plugin

[picnoir]

Good catch for the bash completion issue. I'll have a look at that tonight.

[katexochen]

imo shell completion isn't a strict requirement. I'd suggest we just move it in postInstall for now.. change lgtm.