zfs_2_1: warn about impending deprecation #352402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the release of 2.3.0-rc, we know that 2.3.0 will be coming sometime soon. Per the [ZFS release policy][1], only the current and previous releases are expected to be supported, so 2.1.x will become unsupported. Unfortunately upstream does not have any specific timelines, so we do not know when it will become unsupported, but when it does we will likely backport the removal. As such, begin warning of imminent removal. [1]: https://github.com/openzfs/zfs/blob/6187b194349c5a728c9df8c6842f1866d5c9782a/RELEASES.md
|
@RaitoBezarius I defer partly to you on whether we warn here or just outright remove before 24.11 |
Mic92
reviewed
Nov 4, 2024
| @@ -9,6 +9,7 @@ | |||
| let | |||
| stdenv' = if kernel == null then stdenv else kernel.stdenv; | |||
| in | |||
| lib.warn "zfs_2_1 is likely to become unsupported soon by upstream, and may be removed from NixOS 24.11, consider migrating to zfs_2_2" | |||
There was a problem hiding this comment.
Note that this warning will be also shown for every user that does nix-env -q.
There was a problem hiding this comment.
Maybe we should just remove it instead?
There was a problem hiding this comment.
It also shows up for ofborg, so it needs to be done differently.
|
Superseded by #358811 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of 2.3.0-rc, we know that 2.3.0 will be coming sometime soon. Per the ZFS release policy, only the current and previous releases are expected to be supported, so 2.1.x will become unsupported. Unfortunately upstream does not have any specific timelines, so we do not know when it will become unsupported, but when it does we will likely backport the removal. As such, begin warning of imminent removal.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.