Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmic-wallpapers: 1.0.0-alpha.2 -> 1.0.0-alpha.3 #352701

Merged

Conversation

Pandapip1
Copy link
Contributor

Removes an unintentionally unlicensed wallpaper and adds a licence for system76's own wallpaper.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pandapip1 Pandapip1 added the 1.severity: legal This PR or issue raises or fixes a legal issue, e.g. licensing compliance label Oct 31, 2024
@a-kenji
Copy link
Contributor

a-kenji commented Nov 1, 2024

@Pandapip1
The alpha.3 tag is out since yesterday.
Would using that be sufficient?

@Pandapip1 Pandapip1 force-pushed the update-cosmic-wallpapers-2024-10-31 branch from cb669f2 to e1385bd Compare November 1, 2024 17:19
@Pandapip1 Pandapip1 changed the title cosmic-wallpapers: 1.0.0-alpha.2 -> 1.0.0-alpha-unstable-2024-10-31 cosmic-wallpapers: 1.0.0-alpha.2 -> 1.0.0-alpha.3 Nov 1, 2024
@Pandapip1
Copy link
Contributor Author

The alpha.3 tag is out since yesterday.
Would using that be sufficient?

Yup; I must have made this PR right before the tag was made. I remember checking.

@a-kenji
Copy link
Contributor

a-kenji commented Nov 3, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352701


x86_64-linux

✅ 1 package built:
  • cosmic-wallpapers

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 3, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2082

Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you for the detailed comments in the meta.license field!

@tomodachi94 tomodachi94 merged commit 794a81d into NixOS:master Nov 6, 2024
33 of 34 checks passed
@tomodachi94 tomodachi94 removed the 1.severity: legal This PR or issue raises or fixes a legal issue, e.g. licensing compliance label Nov 6, 2024
@Pandapip1 Pandapip1 deleted the update-cosmic-wallpapers-2024-10-31 branch November 6, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants