Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-sync: unstable-2022-03-20 → unstable-2024-02-15 (#352760) #352779

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

RedEtherbloom
Copy link
Contributor

Updated version and hash of git-sync to most recent commit(software has no releases).

One of the changes included is a rewrite of the repository cloning and mkdir logic.
The current version of the package still has the problem that it can't properly clone to locations which contain a whitespace.
This issue gets fixed via this update.

Closes #352760.
Affects home-managerr bug #6023.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable: (package has no tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.(Unsure if I'm supposed to check this myself. I've read most relevant sections for the PR/commit procedure)

Add a 👍 reaction to pull requests you find important.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 1, 2024
@emilazy emilazy merged commit 8b67cf8 into NixOS:master Nov 3, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: git-sync 2022-03-20 → 2024-02-15
5 participants