Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.pytorch-bench: init at unstable-2024-07-18 #352827

Merged
merged 2 commits into from
Nov 2, 2024
Merged

python312Packages.pytorch-bench: init at unstable-2024-07-18 #352827

merged 2 commits into from
Nov 2, 2024

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Nov 1, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium November 1, 2024 10:15
@drupol drupol force-pushed the push-popstrrnqylu branch 2 times, most recently from 5c4aba7 to 710f573 Compare November 1, 2024 10:51
@drupol drupol changed the title python312Packages.torch-benchmark: init at unstable-2024-07-18 python312Packages.pytorch-bench: init at unstable-2024-07-18 Nov 1, 2024
GaetanLepage
GaetanLepage requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor details.

pkgs/development/python-modules/torchprofile/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/torchprofile/default.nix Show resolved Hide resolved
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352827

x86_64-linux

✅ 8 packages built:
  • python311Packages.pytorch-bench
  • python311Packages.pytorch-bench.dist
  • python311Packages.torchprofile
  • python311Packages.torchprofile.dist
  • python312Packages.pytorch-bench
  • python312Packages.pytorch-bench.dist
  • python312Packages.torchprofile
  • python312Packages.torchprofile.dist

aarch64-linux

✅ 8 packages built:
  • python311Packages.pytorch-bench
  • python311Packages.pytorch-bench.dist
  • python311Packages.torchprofile
  • python311Packages.torchprofile.dist
  • python312Packages.pytorch-bench
  • python312Packages.pytorch-bench.dist
  • python312Packages.torchprofile
  • python312Packages.torchprofile.dist

x86_64-darwin

✅ 8 packages built:
  • python311Packages.pytorch-bench
  • python311Packages.pytorch-bench.dist
  • python311Packages.torchprofile
  • python311Packages.torchprofile.dist
  • python312Packages.pytorch-bench
  • python312Packages.pytorch-bench.dist
  • python312Packages.torchprofile
  • python312Packages.torchprofile.dist

aarch64-darwin

✅ 8 packages built:
  • python311Packages.pytorch-bench
  • python311Packages.pytorch-bench.dist
  • python311Packages.torchprofile
  • python311Packages.torchprofile.dist
  • python312Packages.pytorch-bench
  • python312Packages.pytorch-bench.dist
  • python312Packages.torchprofile
  • python312Packages.torchprofile.dist

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 1, 2024
GaetanLepage
GaetanLepage approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good !

@drupol
Copy link
Contributor Author

drupol commented Nov 1, 2024

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@drupol merge not permitted (#305350):
pkgs/development/python-modules/pytorch-bench/default.nix is not in pkgs/by-name/
pkgs/development/python-modules/torchprofile/default.nix is not in pkgs/by-name/
pkgs/top-level/python-packages.nix is not in pkgs/by-name/

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 1, 2024
@GaetanLepage
Copy link
Contributor

Let's maybe wait for ogborg

@drupol drupol merged commit 877fcd2 into NixOS:master Nov 2, 2024
27 of 29 checks passed
@drupol drupol deleted the push-popstrrnqylu branch November 2, 2024 08:41
@drupol drupol mentioned this pull request Nov 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drupol @GaetanLepage @wegank