python312Packages.pysatochip: fix build #352942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
itepastra
added
the
0.kind: ZHF Fixes
|
@itepastra Any reason this is still a draft ? It seems to be working now. |
|
I need to rebase it since pyscard was fixed in a different pr and haven't had the time (tests and getting distracted) |
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
itepastra
changed the title
jopejoe1
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 352942
x86_64-linux
❌ 2 packages failed to build:
- electron-cash
- electron-cash.dist
✅ 4 packages built:
- python311Packages.pysatochip
- python311Packages.pysatochip.dist
- python312Packages.pysatochip
- python312Packages.pysatochip.dist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #352828
ZHF: #352882
Fix the build of pysatochip by fetching from github instead of pypi since some needed files were not in the pypi version.
Also removed the substitutions since these got fixed in the package itself
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.