{febio, febio-studio}: darwin sdk refactor #352943
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I don’t remember why I did this in #331864 but probably I had a reason. |
|
Interesting... looking upstream they had available checks for 10.13 so I assumed it wouldn't need to do anything. |
|
That’s backwards: the 10.12 SDK cannot compile code with availability checks for 10.13+ APIs, because it doesn’t have the 10.13+ APIs. Availability checks are a runtime thing: you need an SDK that is at least the maximum of all availability checks. Rarely, things will use the preprocessor |
|
|
Interesting... FAILED: CMakeFiles/FEBioStudio.dir/FEBioStudio/FileViewer.cpp.o
/nix/store/d2jm2gdf5qmyfbqk579f7h65sbi497sr-clang-wrapper-16.0.6/bin/clang++ -DFFMPEG -DHAS_SSH -DHAVE_ZLIB -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_OPENGLWIDGETS_LIB -DQT_OPENGL_LIB -DQT_WIDGETS_LIB -DTETLIBRARY -D__APPLE__
-I/tmp/nix-build-febio-studio-2.7.drv-0/source/build/CMakeFiles/AutoGen/FEBioStudio_autogen/include -I/tmp/nix-build-febio-studio-2.7.drv-0/source/.
-F/nix/store/nzfcir6lrdq1dx2vkwl5xv996p60zhnq-apple-sdk-12.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks -isystem /nix/store/24n4sn70knrm4ma6g8j3dv4xfbq2axvj-qtbase-6.8.0/lib/QtCore.framework/Headers -iframework
/nix/store/24n4sn70knrm4ma6g8j3dv4xfbq2axvj-qtbase-6.8.0/lib -isystem /nix/store/24n4sn70knrm4ma6g8j3dv4xfbq2axvj-qtbase-6.8.0/mkspecs/macx-clang -isystem /nix/store/24n4sn70knrm4ma6g8j3dv4xfbq2axvj-qtbase-6.8.0/lib/QtWidgets.framework/Headers -isystem
/nix/store/24n4sn70knrm4ma6g8j3dv4xfbq2axvj-qtbase-6.8.0/lib/QtGui.framework/Headers -isystem /nix/store/24n4sn70knrm4ma6g8j3dv4xfbq2axvj-qtbase-6.8.0/lib/QtNetwork.framework/Headers -isystem /nix/store/24n4sn70knrm4ma6g8j3dv4xfbq2axvj-qtbase-6.8.0/lib/QtOpenGL.framework/Headers -isystem /nix/store/24n4sn70knrm4ma6g8j3dv4xfbq2axvj-qtbase-6.8.0/lib/QtOpenGLWidgets.framework/Headers -O3 -DNDEBUG -std=gnu++17 -isysroot /nix/store/nzfcir6lrdq1dx2vkwl5xv996p60zhnq-apple-sdk-12.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -mmacosx-version-min=10.15
-F/nix/store/6sqx120cqlp20k69fp5al6aji6rri5k0-apple-sdk-10.12.2/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks -w -fPIC -MD -MT CMakeFiles/FEBioStudio.dir/FEBioStudio/FileViewer.cpp.o -MF CMakeFiles/FEBioStudio.dir/FEBioStudio/FileViewer.cpp.o.d -oCMakeFiles/FEBioStudio.dir/FEBioStudio/FileViewer.cpp.o -c /tmp/nix-build-febio-studio-2.7.drv-0/source/FEBioStudio/FileViewer.cpp
/tmp/nix-build-febio-studio-2.7.drv-0/source/FEBioStudio/FileViewer.cpp:651:17: error: variable has incomplete type 'QDirIterator'
QDirIterator it(path, { "*.fs2", "*.fsm", "*.feb", "*.xplt" }, QDir::AllEntries | QDir::NoSymLinks | QDir::NoDotAndDotDot);
^
/nix/store/24n4sn70knrm4ma6g8j3dv4xfbq2axvj-qtbase-6.8.0/lib/QtCore.framework/Headers/qdir.h:17:7: note: forward declaration of 'QDirIterator'
class QDirIterator;
^
1 error generated. |
|
Qt 6.8 issue? |
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 0
Just came back to this, tried building it on master and see the same error. |
khaneliman
changed the title
khaneliman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.