PHP packages & extensions ZHF #352945
Merged
PHP packages & extensions ZHF #352945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZHF NixOS#352882 Doesn't compile with PHP 8.3: https://hydra.nixos.org/build/276605925 We actually want to use the `couchbase-php-client`[1] repo. I briefly tried to package it, but given that I don't care a bit about this specific extension and it was far too annoying (vendored C++ libraries, .gitattributes removing CMake files from the GitHub tarball, a random CMake "package manager" is used) I decided to not bother. If nobody steps up, I'd suggest to throw it out when PHP 8.2 becomes EOL. [1] https://github.com/couchbase/couchbase-php-client/
https://hydra.nixos.org/build/276557313 We have to await version 6.0 to support PHP 8.4.
See https://hydra.nixos.org/build/275613910 The issue that symbols from `session.so` cannot be loaded doesn't happen when building a PHP with ext-soap enabled. To me it seems as if PHP just doesn't find it on runtime. My current hypothesis is that this is because ext-soap now depends on ext-session[1]. [1] php/php-src@c7797fc
I originally wanted to investigate what went wrong here, but I guess that the tag just got force-pushed. See https://hydra.nixos.org/build/276639542
Ma27
commented
Nov 1, 2024
| @@ -663,7 +663,7 @@ in { | |||
| # Some tests are causing issues in the Darwin sandbox with issues | |||
| # such as | |||
| # Unknown: php_network_getaddresses: getaddrinfo for localhost failed: nodename nor servname provided | |||
| doCheck = !stdenv.hostPlatform.isDarwin; | |||
| doCheck = !stdenv.hostPlatform.isDarwin && lib.versionOlder php.version "8.4"; | |||
There was a problem hiding this comment.
See the commit message for the rationale. If somebody has a better solution, I'm all for it.
patka-123
approved these changes
Nov 1, 2024
wegank
added
the
12.approvals: 1
ofborg
bot
added
11.by: package-maintainer
piotrkwiecinski
approved these changes
Nov 2, 2024
wegank
added
12.approved-by: package-maintainer
|
hey @piotrkwiecinski ! Long time no see! All good? |
drupol
approved these changes
Nov 2, 2024
|
hi @drupol . All good. Live happened. I'm slowly getting back to contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks a bunch of things as broken and fixes
psyshandphp84Extensions.soap.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.